Awesome! Thanks for the feedback -- you are super fast.
I went ahead and polished up the focus mode selection and added error messages throughout. Now it takes into account every situation that I can think of. This includes unfortunate scenario when you are using face detection but no faces are detected, and the camera does not store any useful focus information.
The main reason I did that is because Pentax cameras (at least the K-50 and K-1) do not store anything useful in "AFPointSelected" when using the auto-select mode. So basically, you'd just have red dot and nothing else around it. With the inactive points, you get an overview of every point in focus within the entire set of points.
This camera has some pretty poor AF behavior in general. You'll notice from the image that it will indicate that 2 points are in focus when only one is selected, etc. That is a shitty AF system bug that the plugin handles quite correctly, so no biggie. Also, this camera only has 11 points; this might look poor for a camera with many more points. I think your idea about adding a button is good, and should be simple once the interface is little bit more fleshed-out.
Anyway, I think the Pentax stuff works well enough for the K-50 that I can safely add other cameras. I'll start with reddit and see if there are people willing to help out with raw files or by mapping points. Also, let me know if you want me to add some sample images to your other repo.
Awesome! Thanks for the feedback -- you are super fast.
I went ahead and polished up the focus mode selection and added error messages throughout. Now it takes into account every situation that I can think of. This includes unfortunate scenario when you are using face detection but no faces are detected, and the camera does not store any useful focus information.
About the inactive focus points:
I uploaded an album with some sample shots here.
The main reason I did that is because Pentax cameras (at least the K-50 and K-1) do not store anything useful in "AFPointSelected" when using the auto-select mode. So basically, you'd just have red dot and nothing else around it. With the inactive points, you get an overview of every point in focus within the entire set of points.
This camera has some pretty poor AF behavior in general. You'll notice from the image that it will indicate that 2 points are in focus when only one is selected, etc. That is a shitty AF system bug that the plugin handles quite correctly, so no biggie. Also, this camera only has 11 points; this might look poor for a camera with many more points. I think your idea about adding a button is good, and should be simple once the interface is little bit more fleshed-out.
Anyway, I think the Pentax stuff works well enough for the K-50 that I can safely add other cameras. I'll start with reddit and see if there are people willing to help out with raw files or by mapping points. Also, let me know if you want me to add some sample images to your other repo.