'*' in Pentax mapping files

musselwhizzle / Focus-Points

Plugin for Lightroom to show which focus point was active in the camera when a photo was taken

Apache License 2.0

346 stars 42 forks source link

'*' in Pentax mapping files #141

Closed ropma closed 5 years ago

ropma commented 5 years ago

Some Pentax mapping files contain an invalid character. '*' is not supported on Windows files systems.

Even if the is not an issue for the currently supported platform Mac, this is a prerequisite for the Windows version I'm working on.

Pull request is coming.

musselwhizzle commented 5 years ago

Thanks for the changes. I was just looking last night at the code and was planning out my attack again for windows. If you're tackling it, i can hold off.

ropma commented 5 years ago

Yes, I already have a first version using mogrify to do the rendering under Windows. Some more testing is needed

musselwhizzle commented 5 years ago

in terms of the structure, hopefully we can just make https://github.com/musselwhizzle/Focus-Points/blob/master/focuspoints.lrdevplugin/DefaultPointRenderer.lua#L188 just return the correct view based upon the OS. Or maybe modify that file to separate the math logic of where to place it from the actual building of the views. I think that's probably the best place to patch the code in. Also, if you do contribute please release it under the same licensing as already in the repo