Windows version for Focus-Point plugin

[ropma]

• enhance InfoProvider with option section for mogrify
• DefaultPointRenderer.createView returns the final photo view including overlays / mogrify frames
• the old implemenation of "createView" is splitted into two new methods
  • prepareRendering: rendering independent part
  • createOverlayViews: create overlay views
• new helper class MogrifyUtils for mogrify handling (export to disk, create focus frames)

closes #70

[musselwhizzle]

FYI, i changed this into a branch called "windows_support" so that i can make sure all the mac stuff still works. I'll merge those two branches once I can QA.

[capricorn8]

Really really looking forward to using this as well. As soon something is available to test on windows I'm ready to do so :-)

[musselwhizzle]

Error on mac. haven't looked into it yet

[capricorn8]

Great job !!! 👍👍

Works like a charme for my Olympus ORF files on Win10, with one exception. For some files I get an Digging deeper, it seems that for these files there is a problem with improper input to mogrify. When I execute the command printed in the logfile on command line

_>magick.exe mogrify -fill none -strokewidth 3 -stroke red -draw "roundRectangle 434,524 335,591 1,1" C:\Temp\P4001793-fpoints.jpg

I get the following:

mogrify: non-conforming drawing primitive definition `roundRectangle' @ error/draw.c/RenderMVGContent/4396.

See attached file to reproduce the issue.

P4001793.zip

[ropma]

When I execute the command printed in the logfile on command line

_>magick.exe mogrify -fill none -strokewidth 3 -stroke red -draw "roundRectangle 434,524 335,591 1,1" C:\Temp\P4001793-fpoints.jpg

I get the following:

mogrify: non-conforming drawing primitive definition `roundRectangle' @ error/draw.c/RenderMVGContent/4396.

See attached file to reproduce the issue.

P4001793.zip

Great job !!! 👍👍

Works like a charme for my Olympus ORF files on Win10, with one exception. For some files I get an Digging deeper, it seems that for these files there is a problem with improper input to mogrify. When I execute the command printed in the logfile on command line

_>magick.exe mogrify -fill none -strokewidth 3 -stroke red -draw "roundRectangle 434,524 335,591 1,1" C:\Temp\P4001793-fpoints.jpg

I get the following:

mogrify: non-conforming drawing primitive definition `roundRectangle' @ error/draw.c/RenderMVGContent/4396.

See attached file to reproduce the issue.

P4001793.zip

Thank you for testing and the feedback. I'll checked the file in the attachment and couldn't reproduce the problem. The focus point is shown at the head. Which windows version are you using?

[ropma]

Error on mac. haven't looked into it yet

That's strange. Does the Mac version try to use mogrify? Before I added mogrify to the distribution is was also possible on a Mac to use mogrify. This was handled by a prefs param which was set in the Option dialog of the info provider. This parameter still exist. I'll make an update, maybe that's the root case of the problem.

[capricorn8]

Thank you for testing and the feedback. I'll checked the file in the attachment and couldn't reproduce the problem. The focus point is shown at the head.

That is strange indeed. For this, and few other files the error is clearly reproducible on my end.

Which windows version are you using?

Lightroom Classic-Version: 8.4.1 [ 201909111355-eb9b68f0 ] Lizenz: Creative Cloud Spracheinstellung: de Betriebssystem: Windows 10 - Business Edition Version: 10.0.18362 Anwendungsarchitektur: x64

[capricorn8]

I guess I found the reason.

Looking at how the parameters for "draw roundRectangle" are composed in your code, the logic of top-left and bottom-right coordinates does not match with the actual figures in the logfile above, where this is exactly reversed: (434,521)=br, (335,591)=tl.

And indeed, those images where the problem occurs have been flipped horizontally during editing in LR with regard to their original orientation.

Are you able to you detect / handle this?

[ropma]

Thanks for the analysis. I'll check this.