search

musselwhizzle / Focus-Points

Plugin for Lightroom to show which focus point was active in the camera when a photo was taken
Apache License 2.0
346 stars 42 forks source link

remove LR preference mogrifyUsage #145

Closed ropma closed 5 years ago

ropma commented 5 years ago

With the removal of the options section, there isn't any UI to the set or unset the LR preference parameter mogrifyUsage. Thus the usage of the parameter is removed.

I don't know if this fix also solves the load problem of MogrifyUtils on a Mac.

musselwhizzle commented 5 years ago

I'll need about 4 days before I can test it out

ropma commented 5 years ago

No problem - thanks.

The second commit fixes the rendering problem with flipped images reported in PR #143. And also contains some minor code improvements (missing keyword 'local' for local variables)

musselwhizzle commented 5 years ago
Screen Shot 2019-10-07 at 4 26 13 PM

This is what shows up immediately when I try to open it on mac. I can't figure out where it's coming from. Maybe something with the editor you used isn't compatible with Mac?

musselwhizzle commented 5 years ago

Usually uninstalling the plugin and reinstalling it fixes it whenever a new class file is added, but that's not doing the trick here for me.

ropma commented 5 years ago

MogrifyUtils essentially creates a command line, which is then executed using LrTask.execute (similar to ExifUtils). There are no direct dependencies to the ImageMagick/Mogirfy installation. I used a LUA 5.1 compiler to check the syntax during development . I don't understand why there a loading problem on a Mac. I will ask a friend if I can do a test on his Macbook...

musselwhizzle commented 5 years ago

Hopefully i can work on it this weekend too

musselwhizzle commented 5 years ago

I deleted everything I had locally and then reinstalled it fresh and it worked. Must had been something weird on my part. Looks great. I'm going to merge this over into master now. Nice job!