musselwhizzle / Focus-Points

Plugin for Lightroom to show which focus point was active in the camera when a photo was taken
Apache License 2.0
345 stars 42 forks source link

fails with olympus .orf files from em1 mark2 as well as nikon z7 .nef files #148

Closed bwanaaa closed 4 years ago

bwanaaa commented 4 years ago
Screen Shot 2019-11-04 at 7 15 56 PM Screen Shot 2019-11-04 at 7 17 06 PM

It does show the metadata from these files. And it DOES work with Fuji x100f .raf files.

musselwhizzle commented 4 years ago

that's not this project. you're welcome to try this one.

bwanaaa commented 4 years ago

sorry i initially posted the wrong screenshot.

bwanaaa commented 4 years ago

OS is MacBook pro running Mojave

musselwhizzle commented 4 years ago

can you zip and attach the files in question?

bwanaaa commented 4 years ago

thank you for reopening this issue. I also tried it on a win 10 pro machine with Lightroom 8.3. same results. Both of the raw files in this archive can be opened and edited in lightroom. However the plugin starts to calculate the focus point, a progress bar appears and then I get the 'no joy' dialog. The files are big (because they are the original raws). Here is a link to a dropbox archive https://www.dropbox.com/s/xg4je3udm83nm95/raw%20files.zip?dl=0

capricorn8 commented 4 years ago

I cannot open the dropbox link. ("404 Diese Datei befindet sich nicht mehr an diesem Speicherort.")

Have you checked the "Show Metadata" output? I n particular, "AF" related fields and further down in the list, Focus Mode".

bwanaaa commented 4 years ago

Sorry about that. Dropbox never synced the zip. Here is a direct link to one of the raw files that I AM SURE is there

https://www.dropbox.com/s/j5db2sbm82vdvlx/_A180118.ORF?dl=0

Exactly where are these checkboxes? No dialog is produced by the plugin with them.

capricorn8 commented 4 years ago

No problem; I now could download the file. When referring to "Show Metadata" I was talking about the second function of this plugin which is a plain textual report of EXIF metadata that reflect how the camera was configured while capturing the image.

image

This is very helpful to figure out why an AF point cannot be diplayed. In your case: AF Areas = none AF Point Selected = n/a AF Ready = Not Ready which suggests that for this image you have pressed the shutter before focusing was complete.

@musselwhizzle: In case the "focus point not found" dialog pops up it would be nice to have the option to directly proceed to "Show Metadata" and figure out why the plugin is not able to do its job. This could also prevent new users from hastily reporting errors.

musselwhizzle commented 4 years ago

Good idea @capricorn8

bwanaaa commented 4 years ago

ok. Well look at this raw file.

https://www.dropbox.com/s/jonfygar2feaim6/DSC_0001.NEF?dl=0

The metadata show an autofocus point

Screen Shot 2019-11-05 at 6 52 22 PM

but the plugin still fails

Screen Shot 2019-11-05 at 6 52 45 PM
bwanaaa commented 4 years ago

btw, here is the focus point that nikon nx-d software properly shows in dark magenta as a square in the image

Screen Shot 2019-11-05 at 6 59 02 PM
ropma commented 4 years ago

The EXIF data contains Live View Focus Points ("AF Area xx") and also the "Primary AF Point":

11/07/2019 22:38:09 DEBUG EXIFUTILS | Parsed 'AF Area Height' = '324' 11/07/2019 22:38:09 DEBUG EXIFUTILS | Parsed 'AF Area Mode' = 'Single' 11/07/2019 22:38:09 DEBUG EXIFUTILS | Parsed 'AF Area Width' = '292' 11/07/2019 22:38:09 DEBUG EXIFUTILS | Parsed 'AF Area X Position' = '2568' 11/07/2019 22:38:09 DEBUG EXIFUTILS | Parsed 'AF Area Y Position' = '2168' 11/07/2019 22:38:09 DEBUG EXIFUTILS | Parsed 'AF Fine Tune' = 'Off' 11/07/2019 22:38:09 DEBUG EXIFUTILS | Parsed 'AF Fine Tune Adj' = '0' 11/07/2019 22:38:09 DEBUG EXIFUTILS | Parsed 'AF Fine Tune Index' = 'n/a' 11/07/2019 22:38:09 DEBUG EXIFUTILS | Parsed 'AF Image Height' = '5504' 11/07/2019 22:38:09 DEBUG EXIFUTILS | Parsed 'AF Image Width' = '8256' 11/07/2019 22:38:09 DEBUG EXIFUTILS | Parsed 'AF Info 2 Version' = '0300' 11/07/2019 22:38:09 DEBUG EXIFUTILS | Parsed 'AF Points Used' = '(none)' .. 11/07/2019 22:38:09 DEBUG EXIFUTILS | Parsed 'Primary AF Point' = 'C6 (Center)'

In the algorithm the "Primary AF Point" has priority over the live view AF points. As the is no mapping file for the Z 7 the display of the primary AF point (C6) fails.

According to the screenshot above the Live View focus point was used (and not the center point)

For testing I've commented out the handling of the "Primary AF Point" and get now the same result as the Nikon Software:

image

Maybe for the Z7 the live view AF points should have priority of the Primary AF point? But I don't have a Z7, thus I can't do more tests.

musselwhizzle commented 4 years ago

@bwanaaa - looks like the issue is your camera isn't listed in the supported cameras as @ropma points out. (I should add error messaging to show that.) You're welcome to follow the steps on how to make a mapping file. Unfortunately, Nikon's focus points aren't given dynamically like every other manufacture.

https://github.com/musselwhizzle/Focus-Points#adding-your-own-camera

bwanaaa commented 4 years ago

@ropma Thank you! I looked in the file \Focus-Points-master\focuspoints.lrdevplugin\bin\exiftool\lib\Image\ExifTool\Nikon.pm and found numerous references to the variable 'PrimaryAFPoint'

At line 3433 I found thiis

     Name => 'PrimaryAFPoint',
        Condition => '$$self{AFInfo2Version} eq "0100"',
        Notes => 'future models?...',
        PrintConv => {
            0 => '(none)',
            1 => 'Center',
        },
    },

Is this the section you commented out(deleted)? I could find no reference to a ' Live View focus point'

ropma commented 4 years ago

@bwanaaa

No!

Line 86 in /Focus-Points/focuspoints.lrdevplugin/DefaultDelegates.lua :

-- local selectedPoint = ExifUtils.findFirstMatchingValue(metaData, DefaultDelegates.metaKeyAfPointSelected)

Please keep in mind: this will BREAK at least the support of Nikon DSLRs. And I don't know if it works with other shots / focus modes of the Z7.

For further analysis: could you provide three more shots with your Nikon Z 7? First with the focus point in the middle, second with the focus point in the upper left corner and third in the lower right corner.

musselwhizzle commented 4 years ago

close ticketing. Resolution: camera is just not supported. We welcome @bwanaaa to follow the README and add the camera support.