search

musselwhizzle / Focus-Points

Plugin for Lightroom to show which focus point was active in the camera when a photo was taken
Apache License 2.0
340 stars 42 forks source link

Plugin not showing entries on Plugin Extras #169

Closed mbertuol closed 2 weeks ago

mbertuol commented 8 months ago

I have installed the plugin and it does not show any entries on Plugin Extras. What am doing wrong?

Here are some screenshots.

2 Screenshot 2023-11-12 090830 Screenshot 2023-11-12 091146
capricorn8 commented 8 months ago

You're not doing anything wrong. The plugin is designed to appear under the Library -> Plugin Extras menu.

However, it can be easily changed to also work also from the File menu. Just unpack the attached file and replace the info.lua file that came with the plug-in installation with this one.

infolua.zip

mbertuol commented 8 months ago

Thank you so much for your reply. I should have read the instructions more carefully. In the sample below I am showing a screenshot of my screen (resolution below). The viewer cannot have its size adjusted and, therefore, the full image cannot be displayed in it is entirety. The photo was taken with a Sony A7R V (I can confirm it works with this camera and it can be added to the supported cameras list) and its resolution is also shown below. Do you have any recommendation on how to fix this issue? Ideally the viewer windows should not be bigger than the screen it is being displayed.

3

Screenshot 2023-11-12 155544 Screenshot 2023-11-12 155942
capricorn8 commented 8 months ago

Could you provide the image file so I can look into this?

ropma commented 8 months ago

Can also activate debug logging. Reproduce the problem and provide the log file (\Documents\LrClassicLogs\libraryLogger.log.). Don't to the switch logging off again.

Screenshot 2023-11-13 143947

What display resolation has your screen?

Roland

PS: I have no problems with Sony A7R V files.

mbertuol commented 8 months ago

I appreciate your time for looking into this. I made a recording showing my entire screen (resolution 3840x2160). When Lightroom is using about a third of the screen, the plugin viewer shows its window properly. However when Lightroom is maximized, the plugin viewer window goes off boundaries. I have installed it on my laptop and I have experienced the same behavior. The laptop screen resolution is 2880x1800.

I am also sending you a sample image. Since both files are big, I created a zip and made it available to you: https://www.dropbox.com/t/uKcEfws75V9NsFNT

I turned on debugger but could not find any .txt with debug info or any .log file. Where should I find the debug file?

ropma commented 8 months ago

I assume you are running Window.

The name of log file is 'libraryLogger.log'. It is the the folder '_your_username\Documents\LrClassicLogs', e,g, C:\Users\roland\Documents\LrClassicLogs

mbertuol commented 8 months ago

Here you have the debug file:

libraryLogger.log

capricorn8 commented 8 months ago

I'm unable to reproduce this behavior on my Windows machine with QHD monitor (2560x1440).

ropma commented 8 months ago

In the log file I can see, that you made several attempts. The size of created Focus Points windows were 2215x1477 and 1591x1060 pixels respectively. Both should fit on your screen without any problems. Are you using a scale and a different screen resolution (other than the actual resolution of the screen?)

mbertuol commented 8 months ago

I do need to use 150% scaling because the monitor has a 3840 x 2160 native resolution. If I leave the scale at 100%, everything is so tiny on the screen that is very difficult to work. I guess the plugin is not taking into consideration the scale.

image
mbertuol commented 8 months ago

I believe that if you set your scale to 125% or 150% you should be able to reproduce the issue.

ropma commented 8 months ago

I'll check it tomorrow..

mbertuol commented 8 months ago

If I use 100% scale, it shows correctly.

2

capricorn8 commented 8 months ago

I believe that if you set your scale to 125% or 150% you should be able to reproduce the issue.

By default, I use 114%. I now tried with 100%, 150% and 200% but in all cases the focus pointer viewer window shows correctly.

mbertuol commented 8 months ago

Not sure what to do then. In my case it only works at 100% scale…

capricorn8 commented 8 months ago

It might be an issue specifically with LrC 13: https://www.lightroomqueen.com/community/threads/lr-mogrify-add-borders-etc-not-working-with-lrc-13.48607/

There seem to be a number of plugins affected by this, all of them use Mogrify - as the focus point viewer does.

AFAIR @ropma has implemented this part of the plugin, let's see what with he comes up from analyzing your logfile.

ropma commented 8 months ago

Today I've tested the plugin with 125% - and no problem. I'm using the latest Lightroom version 13.0.1

Which version a you using?

PS: I don't it the issue of the lightroomqueen forum. Mogrify seen to work. The screen size is wrong.

mbertuol commented 8 months ago

I am using version 13.0.1 as well. I have the same issue both with my laptop (that has a lower screen resolution) and with my desktop.

I have tested with 4 scale options that my desktop provides me:

image

Here are the results: 100% 100

125% 125

150% (my default) 150

175% 175

200% 200

mbertuol commented 8 months ago

Based on the screenshots above, could you please test at 150%

ropma commented 8 months ago

You are right!! At 150% I have the same problem. I need to investigate a little more..

ropma commented 8 months ago

This is bug in the Lightroom API. For more details see bug report in the Adobe community

The Focus Point plugin use LrSystemInfo..appWindowSize(). I don't see a easy workaround.

mbertuol commented 8 months ago

Ropma, just wondering here... Would it be possible that you could show the focus point(s) as an overlay in every single photo? If we could see as an overlay, there would be no need to open the viewer and would be much easier to choose photos for focus stacking. It would be similar to what you would see in the Sony camera LCD. Imagine something like this:

image
capricorn8 commented 8 months ago

This is bug in the Lightroom API. For more details see bug report in the Adobe community

The Focus Point plugin use LrSystemInfo..appWindowSize(). I don't see a easy workaround.

Plus, the error has already been reported in early 2022. So, there is little hope that this will be fixed at all.

@mbertuol What is the closest scale factor to 150% where this issue doesn't happen?

I'm asking because in the past I had a similar issue with display scaling in PS, resulting in invisible dialogs - see here. Maybe it's sufficient to choose eg. 146%? Have you tried this already?

mbertuol commented 8 months ago

@capricorn8 I am not able to enter any given number in Windows 11 scale option. I can only choose from the dropdown menu. Therefore, it goes from 125% to 150%.

On a different subject, do see any feasibility of having a focus point overlay like the simulation I posted above?

capricorn8 commented 8 months ago

@mbertuol I am also running Windows 11 and can enter a custom scaling factor. Right to the dropdown menu there is a ">" which leads to the "Custom scaling" dialog:

scale

Regarding your question: no, that's not possible because the API does not offer to change or interact with the existing UI.

mbertuol commented 8 months ago

@capricorn8 Thank you for that. I never realized it could be changed that way. I tried 140% and 145% and both did not work.

The only thing that works is changing the font size in Lightroom. Preferences, Interface, Font size. You should choose Medium. Then it displays correctly even though Windows is to 150% scale. The downside is the interface (not the menus though) become too small...

ropma commented 8 months ago

Ropma, just wondering here... Would it be possible that you could show the focus point(s) as an overlay in every single photo?

Using overlays is the idea of the Mac version. But it does work on Windows: see https://github.com/musselwhizzle/Focus-Points/issues/70 The current Windows implementation is a workaround for this issue.

capricorn8 commented 8 months ago

@ropma My interpretation of mbertuol's question whether it would be possible to add a focus point overlay to the original image display in LR, similar to the Loupe Overlay. AFAIR the plugin always had a separate window.

ropma commented 8 months ago

The Lightroom API does not allow to draw or create overlays to the original image display. Thus also the Mac version create a second image window.

Due to a bug in the Windows Lightroom API, it is not possible to determine the available image size and thus calculate the correct window size. But as a workaround you could specify the scaling in the Options dialog and thus calculate the correct window size. What you think?

mbertuol commented 8 months ago

Thank you for the explanation. I could do that if you tell me the steps. As an alternative option, would there be a way to set a fixed window size? Maybe in the info.lua file…

ropma commented 8 months ago

A fixed window size is not flexible, this I not prefer an option for it, e.g.

Screenshot 2023-11-15 142149

ropma commented 8 months ago

I've have created a new local branch in my local repository: https://github.com/ropma/Focus-Points/tree/win_scaling

The branch offers the scaling option. Could you please test it?

mbertuol commented 8 months ago

I've have created a new local branch in my local repository: https://github.com/ropma/Focus-Points/tree/win_scaling

The branch offers the scaling option. Could you please test it?

It worked! I really appreciate your efforts! Thank you so much!

musselwhizzle commented 8 months ago

Anything y'all want to merge in?

On Thu, Nov 16, 2023, 5:12 PM mbertuol @.***> wrote:

I've have created a new local branch in my local repository: https://github.com/ropma/Focus-Points/tree/win_scaling

The branch offers the scaling option. Could you please test it?

It worked! I really appreciate your efforts! Thank you so much!

— Reply to this email directly, view it on GitHub https://github.com/musselwhizzle/Focus-Points/issues/169#issuecomment-1815396842, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARTUQSGCTHBFXLXIO5VZK3YE2FWPAVCNFSM6AAAAAA7IB2WKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJVGM4TMOBUGI . You are receiving this because you are subscribed to this thread.Message ID: @.***>