search

musselwhizzle / Focus-Points

Plugin for Lightroom to show which focus point was active in the camera when a photo was taken
Apache License 2.0
345 stars 42 forks source link

Musselwhizzle/master #47

Closed rderimay closed 7 years ago

musselwhizzle commented 7 years ago

Will move it to a feature branch for now.

musselwhizzle commented 7 years ago

Whenever possible, please have the PRs be focused on 1 specific thing. As it stands, I will pick and pull some code from this, but not accept the PR.

musselwhizzle commented 7 years ago

Heads up if you want to tackle this: https://github.com/musselwhizzle/Focus-Points/issues/48

rderimay commented 7 years ago

I understand, that some PR are difficult to merge but I concentrated on 1 specific thing : making it work on Windows. Doing that a lot of small stuff needed to be done to make sense. The only things which were not related to that is the renaming of FocusPoint in ShowFocusPoint and the refactoring around the one dialog to be more consistent with the other one.

musselwhizzle commented 7 years ago

moved into feature branch.