musselwhizzle / Focus-Points

Plugin for Lightroom to show which focus point was active in the camera when a photo was taken

Apache License 2.0

345 stars 42 forks source link

Cropped on a Rotate 90 CW is incorrect focus point #48

Closed musselwhizzle closed 7 years ago

musselwhizzle commented 7 years ago

There's a new bug that's been introduced with the new code. If a photo was shot at "Rotate 90 CW" and then cropped from what's the human bottom, left the focus point is wrong.

rderimay commented 7 years ago

Please provide an example file / screen shot.

musselwhizzle commented 7 years ago

Error

crop shown

uncropped

project802 commented 7 years ago

No crop or rotation: original_correct

Basic crop/rotation around the center point: rotated_cropped_incorrect

rderimay commented 7 years ago

Thanks will look at it. The transformation code is anyway not clean for me.

No idea what I changed there to make it not work anymore. Maybe this is related to the new json decoding.

musselwhizzle commented 7 years ago

this is on current master.

rderimay commented 7 years ago

ah ok. better then.

project802 commented 7 years ago

If you need it, the NEF from my example above is now in the Focus-Points-Sample-Images master.

musselwhizzle commented 7 years ago

@rderimay if you work on this, please work off of the current master and not any outstanding PRs. This is a separate issue, standalone. It can be merge into other things.

rderimay commented 7 years ago

Cannot make a new PR until PR #47 is accepted (or not) @musselwhizzle. Should you just pick stuff, let me know what and what not please.

musselwhizzle commented 7 years ago

https://github.com/musselwhizzle/Focus-Points/blob/master/Contributing.md The current flow is causing issues.

47 is merged into a feature branch. It will not be in master for now. I suppose since it is already merged, reset your git to the current master "git checkout master; git fetch; git reset --hard origin/master" and that would work.

musselwhizzle commented 7 years ago

So my bug report is inaccurate and I'm going to close the ticket. Basically, originally the image was upside down and I (apparently) rotated it to turn it right side up. Since LR doesn't report rotations, the values are off.

I'm closing the ticket.

project802 commented 7 years ago

The image I attached is straight out of the camera. Rotating it in LR shows the above error. New issue or reopen?

project802 commented 7 years ago

Is #53 where this is now tracked?

rderimay commented 7 years ago

Yes, I will track this at the same time, I have to redo the math to accommodate the fact that a user can also rotate on grid

musselwhizzle commented 7 years ago

@project802 i reopened the issue and will help verify on your file. Can you please link directly to the RAW file for testing.

musselwhizzle commented 7 years ago

@rderimay - assume this is a non issue until we get the file and I can verify.

project802 commented 7 years ago

I'm on mobile but the file is in the sample images under D800 and it's the portrait one. Just pulled in yesterday I think.

musselwhizzle commented 7 years ago

i dont see any sample images: https://github.com/musselwhizzle/Focus-Points-Sample-Images/tree/master/Canon

project802 commented 7 years ago

https://github.com/project802/Focus-Points-Sample-Images/blob/master/Nikon/D800/D800-C9-90deg.NEF

musselwhizzle commented 7 years ago

Verified, but let me make a separate ticket since it's a bit different. Once specific to this issue.

musselwhizzle commented 7 years ago

https://github.com/musselwhizzle/Focus-Points/issues/55