search

musselwhizzle / Focus-Points

Plugin for Lightroom to show which focus point was active in the camera when a photo was taken
Apache License 2.0
345 stars 42 forks source link

User chosen rotation is not taken into account #53

Closed rderimay closed 7 years ago

rderimay commented 7 years ago

Whenever the user chooses to rotate his picture in the grid mode, the current algorithm ignores it. I found a way to get the info from lightroom and would like to implement it.

musselwhizzle commented 7 years ago

assigned to you. have at it.

rderimay commented 7 years ago

Much better way of working on stuff this way. Before you never new if someone else would have started to work on this also...

musselwhizzle commented 7 years ago

should make it a lot easier on me to QA. I only have to QA 1 thing instead of the whole app as well.

mkjanke commented 7 years ago

Similar issue with photos taken in portrait orientation [Olympus]. Focus point is displayed as though image was landscape orientation.

'Orientation' tag in metadata shows 'Rotate 270 CW'.

Using grid view to rotate photo displays correct focus point location .

Sample image: [https://github.com/mkjanke/Focus-Points-Sample-Images/blob/master/Olympus/E-M1MarkII/P1080121.ORF]

Focus point should be directly on the bird.

As displayed: screen shot 2017-01-09 at 6 08 33 pm

Correct focus point location:

screen shot 2017-01-09 at 6 08 54 pm

Is this a new issue, or is this a manifestation of this issue? If new, I'll create as new.

rderimay commented 7 years ago

this is #55

musselwhizzle commented 7 years ago

those are different issues. I see this tickets saying: If you rotate the photo in lightroom, lightroom doesn't report if it's been rotated and thus the focus point is wrong.

I see #55 as saying, rotation during crop isn't working for that photo. I could repo for that 1 photo, but not for mine.

rderimay commented 7 years ago

What I meant, is that the source of the problem is the same in my code. You can let them both open so we can track

musselwhizzle commented 7 years ago

I found a way to get the info from lightroom and would like to implement it. You've found a way that Lightroom will report if I've rotated a photo in library mode or develop mode?

rderimay commented 7 years ago

yes. Better said, it seems that the value takes the Exif value and builds on it depending on what you do. INCLUDING mirroring... Testing right now.

rderimay commented 7 years ago

Solved in #73