search

musselwhizzle / Focus-Points

Plugin for Lightroom to show which focus point was active in the camera when a photo was taken
Apache License 2.0
345 stars 42 forks source link

Make metadata work in windows again #62

Closed rderimay closed 7 years ago

musselwhizzle commented 7 years ago

your original code is all here: https://github.com/musselwhizzle/Focus-Points/tree/feature/rderimay_windows

But all we need to know if add exiftool.exe and set the text to be multiline.

rderimay commented 7 years ago

@musselwhizzle : You write "(Note, dont do this in the metadata viewer as converting to a table will throw out duplicate key names)" This is already what is done in createParts used in the MetadataDialog. So to me, we should use readMetadataAsTable there also and clean up the 3 unused methods. Much quicker to build the Metadata View and known how much line there is etc. I would do it part of this bug, as this is anyway the base of the problem here. ok ?

musselwhizzle commented 7 years ago

as it stands (or stood before today commits) Metadata viewer showed duplicates if there were duplicates in the metadata (see screenshot attached).

screen shot 2017-01-09 at 2 33 31 pm

It was nice for the viewer since the values can change. If you really hate those methods, move them from the utils to the showmetadata class.

Either way, I'd like for this feature to stay.

rderimay commented 7 years ago

ah sorry misread the createParts(metaData) I though it was anyway creating a table but it is creating a numbered table

musselwhizzle commented 7 years ago

https://github.com/musselwhizzle/Focus-Points/pull/64 Resolved