musselwhizzle / Focus-Points

Plugin for Lightroom to show which focus point was active in the camera when a photo was taken
Apache License 2.0
345 stars 42 forks source link

Added Canon EOS 40D #72

Closed profesorek96 closed 7 years ago

profesorek96 commented 7 years ago

Please add to main repository.

rderimay commented 7 years ago

I am pretty sure that should be unneeded as -unless we have a bug- the current version supports the 40D (and almost any Canon camera) without config file.

musselwhizzle commented 7 years ago

do most canon's report their x and y pixel locations just like fuji? I'm feeling very left out that nikon didn't.

We need to update the readme with what canon's we support.

rderimay commented 7 years ago

Indeed yes, I was pretty socked to find no infos at all in the Nikon files I have opened. This is crazy simple to implement for them I cannot understand why they did not. The same as Fuji that implemented a lot of stuff in the Exif (af positions, face recognition squares, etc) but did NOT implement the current chosen size if the af point...

musselwhizzle commented 7 years ago

before I merge or decline, l or you can grab his images out of the image repo and test that the current version works there.

rderimay commented 7 years ago

40 D Output:

EXIF | Searching for AF Area Widths -> 97 97 97 97 97 97 97 97 97 EXIF | Searching for AF Area Heights -> 98 98 98 98 98 98 98 98 98 EXIF | Searching for AF Area X Positions -> 0 -649 649 -1034 0 1034 -649 649 0 EXIF | Searching for AF Area Y Positions -> 562 298 298 0 0 0 -298 -298 -562 EXIF | Searching for AF Points Selected -> 4 EXIF | Searching for { AF Points In Focus } returned nothing

rderimay commented 7 years ago

does he just put some ?

musselwhizzle commented 7 years ago

yes

https://github.com/musselwhizzle/Focus-Points-Sample-Images/tree/master/Canon/EOS%2040D

rderimay commented 7 years ago

ah ok. second

rderimay commented 7 years ago

Works

rderimay commented 7 years ago

capture 2017-01-10 a 23 10 26

rderimay commented 7 years ago

And with rotated, cropped and mirrored ^_^

capture 2017-01-10 a 23 10 55

musselwhizzle commented 7 years ago

to confirm: is it your recommendation to decline this PR.

rderimay commented 7 years ago

yes, all needed info (including width and height) is in the exifs

musselwhizzle commented 7 years ago

declined PR as camera support already exists dynamically.

@profesorek96 - if you find this to be untrue, let's reopen and investigate at that time.