Recoded the rotation calculations on an affine matrix base to support rotation and mirroring

musselwhizzle / Focus-Points

Plugin for Lightroom to show which focus point was active in the camera when a photo was taken

Apache License 2.0

345 stars 42 forks source link

Recoded the rotation calculations on an affine matrix base to support rotation and mirroring #73

Closed rderimay closed 7 years ago

rderimay commented 7 years ago

Added support for rotation in camera and rotation in Lightroom as well as mirroring in Lightroom Corrected a small typo in ExifUtils:94 and commented out unnecessary logging in readMetaDataAsTable

rderimay commented 7 years ago

@musselwhizzle Ok. I think I have it. This branch should solve all issues we had with wrong rotations of points and add support for rotation in camera and in LR as well as mirroring in LR. At least, it works on everything I have tested...

rderimay commented 7 years ago

Test on 40D: capture 2017-01-10 a 23 10 26

And test of mirroring, rotation and cropping: capture 2017-01-10 a 23 10 55

musselwhizzle commented 7 years ago

i can't tell what this PR is supposed to do. this PR was supposed to be about Lightroom not reporting the direction if the images was flipped. There's 870 some new files added. I expected this PR to be 1 or 2 files touched.

rderimay commented 7 years ago

They are 2 files, the rest is only no new mirrored icons because we need them to support mirroring.

This PR is solving issues #55 #53 and adds full support to rotation and mirroring from inside lightroom and rotation in camera by replacing the old crap I wrote in DefaultPointRenderer.createView at the beginning and replacing it by the correct and improved calculations. The holy grale so to say.

musselwhizzle commented 7 years ago

give me a while on this please. There's a good bit to go over. I'll have questions but can't get to it now.

musselwhizzle commented 7 years ago

If I make comments here in this box, it seems you can't reply directly. So I will put all comments on code from now one even if they aren't about code so that the comment thread remains. It's silly you can't reply to a comment....