search

musselwhizzle / Focus-Points

Plugin for Lightroom to show which focus point was active in the camera when a photo was taken
Apache License 2.0
344 stars 42 forks source link

Fix Issue #84 #86

Closed rderimay closed 7 years ago

rderimay commented 7 years ago

Moved method DefaultDelegates.getShotOrientation (not used anymore) to DefaultPointRenderer.getShotOrientation Added a fallback to this method in the case that getRawMetadata("orientation") returns nil

rderimay commented 7 years ago

No we want this method. The exifrotation var is not used anymore, I left it for now just for log purposes in case we would need to understand a bug

Le 12 janv. 2017 à 23:32, Joshua Musselwhite notifications@github.com a écrit :

@musselwhizzle commented on this pull request.

In focuspoints.lrdevplugin/DefaultPointRenderer.lua:

@@ -47,8 +46,7 @@ function DefaultPointRenderer.createView(photo, photoDisplayWidth, photoDisplayH local userRotation, userMirroring = DefaultPointRenderer.getUserRotationAndMirroring(photo)

-- We read the rotation written in the Exif just for logging has it happens that the lightrrom rotation already includes it which is pretty handy

  • -- We should remove the funcGetShotOrientation later if this is proven to work
  • local exifRotation = DefaultPointRenderer.funcGetShotOrientation(photo, metaData)
  • local exifRotation = DefaultPointRenderer.getShotOrientation(photo, metaData) dont you want DefaultPointRenderer .getUserRotationAndMirroring here?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

musselwhizzle commented 7 years ago

ready for it to merge?