Changes required :recycle:

mustabbas / Portfolio

the portfolio is one of the most powerful tools in the software developer toolbox; it’s the easiest way of showing what you’re truly capable of as a developer, and is a quick and simple way for recruiters and hiring managers to get an idea of what you can bring to their teams.

https://mustabbas.github.io/Portfolio/

3 stars 0 forks source link

Changes required :recycle: #13

Open nachosala89 opened 3 years ago

nachosala89 commented 3 years ago

You have done a great work so far! :muscle: However, I will tell you some suggestions in the comments:

chukwuebukaVictor commented 3 years ago

Your work is nice and you observed you git flow professionally but I think you should have used article for each work container in your html instead of div.

nachosala89 commented 3 years ago

I think the code in assets/script.js will be more clear and concise if you wrap all your items in one class and then you apply the changes to the entire class, not to each item separately.

DyaryRaoof commented 3 years ago

I think the use of only one @mediaquery is enough for your project to make your styles.css cleaner and DRY. if you are using a mobile-first approach use the @mediaquery screen and (min-width: 500 px)for example or if you use the desktop-first approach you can use the @mediaquery screen and (max-width: 500 px). over all your code looks clean and the design is great. good job. 👍 👍 💯

DyaryRaoof commented 3 years ago

Also, I think it is best to have your script.js inside your main folder in your repository so that it can be found easier and not in the assetsfolder;