mustachebutter / GodotAutoSurvival

0 stars 0 forks source link

[FEATURE] Fireball #14

Closed mustachebutter closed 2 months ago

mustachebutter commented 3 months ago

Linked Issues

11

17

19

What to implement?


mustachebutter commented 3 months ago

Needs to reposition the damage number back to original position every time it pops ups to the right of the previous number

mustachebutter commented 3 months ago

Work on the Fireball Explosion of AutoSurvival

mustachebutter commented 3 months ago

Current suspected problem is that we're applying the effect by using StatusEffectComponent.ApplyEffectToCharacter and uses the same Burn instance. But it doesn't make sense because Burn only holds a payload of information regarding the status effect and we're applying the same Burn to different targets. image image

mustachebutter commented 3 months ago

Fixed! Each status effect has its own timer. So applying the same instance to nearby targets doesn't make sense. Therefore, I created new instances of the Burn and apply to each of the new targets.

mustachebutter commented 3 months ago

One problem though, the ApplySideTargets still add one single instance of explosion to all of them (essentially reusing the same instance). We need to figure out a better way for AppltSideTargets to be in and prevent the error logs

Screenshot:

image

mustachebutter commented 2 months ago

Fixed. The reason for this error is that OnTargetDied got triggered multiple times due to subscribing constantly on every tick of damage of DOT status effect. It is fixed by moving to StartStatusEffect which is called once on hitting the effect.