mustafa-tariqk / mindscape

Experience the truth of the trip
https://research.cs.queensu.ca/home/cisc498/index.html
MIT License
16 stars 0 forks source link

Testing #21

Closed mustafa-tariqk closed 9 months ago

mustafa-tariqk commented 9 months ago

What does this PR do?

Fixes authentication, along with all functionality outside of a few bugs here and there.

This was changed because the initial implementation was pretty hastily written, so things weren't tested and earlier work more so let a foundation to what exists now.

Github Issue Number

Resolves: #19

Relates to: other closed issues.

Something to note, the on delete cascades don't work, an issue for another time. This PR is already big enough.

Another thing, we're going to have to make changes to the dockerfiles and docker-compose to account for .env stuff.

Author checklist

If any of these points have yet to be satisfied, make sure that you set the title to the format DRAFT #issue-num Title

Reviewer checklist

mustafa-tariqk commented 9 months ago

@BasicallyOk if you could add some random inline comment somewhere and do this for me https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

Would be much appreciated. Also the -18360 lines is 99% getting rid of npx create-react-app as it is deprecated (happened in early 2023). I expect our front end guys will also want more control over their part of the system.

mustafa-tariqk commented 9 months ago

Also something to note, you need a .env file in the server directory to get things going. I've uploaded what I used in Discord, but you mentioned hosting on github in a secure fashion.