search

mustang-project / Heisenberg

2 stars 1 forks source link

Remove interdependent module switches and subset selection of aperture range #103

Open jmdkastro opened 8 years ago

jmdkastro commented 7 years ago

See #110 for some further details.

jmdkastro commented 4 years ago

@alexhygate is this now addressed in #189 ?

alexhygate commented 4 years ago

1) For "Remove interdependent module switches"

These are the module switches I think you are referring to:

https://github.com/mustang-project/Heisenberg/blob/15d4825f99cf72982ec2faed115145633c82942d/input_file#L45-L60

At first glance they look like they control different parts of the code from each other. However, some may be interdependent or not be needed, for example derivephys. #110 concerns crashing of the code with derivephys = 0, I just did a quick test setting derivephys = 0 and the result is that the code crashes, so derivephys must currently be set to 1 to avoid the code crashing.

 ==> writing output files
% Variable is undefined: EXT.
% Execution halted at: $MAIN$           1532 tuningfork.pro

There may be other keywords that are now redundant.

2) I'm not 100% sure what you mean by "subset selection of aperture range". Do you mean these keywords in the input file that let a user select a subrange of the total apertures they ask Heisenberg to calculate?

https://github.com/mustang-project/Heisenberg/blob/15d4825f99cf72982ec2faed115145633c82942d/input_file#L108-L110

If so, I'd say it's better to keep this functionality, rather than removing it.