search

mutability / dump1090

Dump1090 is a simple Mode S decoder for RTLSDR devices
528 stars 137 forks source link

Fix DB JSON 404, fix favicon 404 by adding one #157

Closed toofishes closed 5 years ago

toofishes commented 8 years ago

This fixes the two 404 errors that show up in my nginx logs. Add a super-simple stub empty JSON file for the non-ICAO addresses, and build a simple favicon derived from the default airplane image used on the map.

favicon example 
nginx[28910]: 2016/10/15 14:16:20 [error] 28914#28914: *16457 open() "/usr/share/dump1090-mutability/html/favicon.ico" failed (2: No such file or directory), server: localhost, request: "GET /favicon.ico HTTP/1.1"
nginx[28910]: 2016/10/15 14:16:26 [error] 28914#28914: *16455 open() "/usr/share/dump1090-mutability/html/db/~.json" failed (2: No such file or directory), server: localhost, request: "GET /db/~.json HTTP/1.1"
mutability commented 8 years ago

Think I'd prefer to mask the request for ~.json so it never happens in the first place

toofishes commented 8 years ago

That is fair. I'm working on a fix for #149 and can incorporate a fix in there.

toofishes commented 8 years ago

@mutability - updated the PR here to reflect your thoughts, as well as fully fixing #149. There is no more stub ~.json file anymore. Let me know what you think.

toofishes commented 8 years ago

Thoughts here?

mutability commented 8 years ago

Looks good from a quick look. Can you break out the nodejs tweaks?