search

mutability / dump1090

Dump1090 is a simple Mode S decoder for RTLSDR devices
528 stars 137 forks source link

Makefile updates #187

Closed labomb closed 7 years ago

labomb commented 7 years ago

Depending on how a user gets the repo, it may not include tags, which can generate "fatal: No names found, cannot describe anything." messages as each object is built. The --always flag will fall back to an abbreviated hash if it can't find any suitable tags, and no "fatal" messages are generated.

mutability commented 7 years ago

I can't reproduce the git describe problem with a fresh clone, but it probably doesn't hurt to have that change.

mutability commented 7 years ago

The CFLAGS_RTL change is redundant; see the rule for dump1090.o

(A reminder to put different things in different PRs; I can't merge this as-is because I only want one of the changes)

labomb commented 7 years ago

When using 'git clone...', tags shouldn't be missing, and one shouldn't encounter the "no names" error. Downloading a zip archive is a different story, and how I encountered the issue.

I did miss the dump.o rule, but I still got bit because it's only partially complete (should be pkg-config --cflags librtlsdr libusb-1.0).

I'll close this PR and submit 2 new ones...thx.

mutability commented 7 years ago

Ah, the broken librtlsdr pkg-config strikes again I guess. We shouldn't need to mention libusb at all..

labomb commented 7 years ago

Too many variations of the librtlsdr package... wish we'd all just settle on yours :).

Romeo-Golf commented 7 years ago

+1 on there being too many forks of librtlsd..

However https://github.com/mutability/rtl-sdr is advertised as being "a very experimental branch - it's probably broken!" it may not be the best one to standardise on...

Unfortunately the osmocom development practice of not accepting pull requests via github doesn't help encourage community contributions..

So if I had to settle on one, the most actively developed stable fork of this code appears to be https://github.com/librtlsdr/librtlsdr :)

mutability commented 7 years ago

It's good to be enthusiastic but +1s do not add anything useful. Half my github notifications are your +1s.