search

mutationpp / Mutationpp

The MUlticomponent Thermodynamic And Transport library for IONized gases in C++
GNU Lesser General Public License v3.0
108 stars 58 forks source link

94 bug fix #109

Closed jbscoggi closed 4 years ago

jbscoggi commented 4 years ago

Solves #94 - FPE or NaN when computing equilibrium cp for a single species mixture. A new test has been also added to ensure the problem does not come back.

jbscoggi commented 4 years ago

Hey @rubendibattista, any idea why the tests are no longer run on PRs? I thought this was working with github actions now?

rdbisme commented 4 years ago

I guess it's a bug: https://github.com/sdras/awesome-actions/issues/98

Try to push to a branch of this project instead of a fork and let's see what it happens.

Sincerely I think that Gitlab is a fairly superior product than Github. Their CI is less cumbersome (and I've more experience with) and it's more integrated. You could still autopush to a read only mirror on GH for visibility. 😉.