search

mutationpp / Mutationpp

The MUlticomponent Thermodynamic And Transport library for IONized gases in C++
GNU Lesser General Public License v3.0
106 stars 58 forks source link

Fortran wrapper access to heavyThermalDiffusionRatios #118

Closed ChiaraAmato closed 4 years ago

ChiaraAmato commented 4 years ago

I have implemented the function "heavyThermalDiffusionRatios" in both cwrapper.h and cwrapper.cpp following the function "frozenThermalConductivity". However, when I run a testcase usign N2 and O2, I received that the Thermal diffusion ratios are zero for both species. Furthermore, can you confirm that the "heavyThermalDiffusionRatios" function is evaluating the coefficients for the temperature term in the diffusive velocities for the Stefan-Maxwell equation?

cwrapper.zip

rdbisme commented 4 years ago

Ehi @ChiaraAmato, maybe it would have a better luck if you can provide a Pull Request. So we can maybe comment your modifications directly there.

Do you think you can do that?

ChiaraAmato commented 4 years ago

Yes, I can. I just need to create a branch and then a “pull request”, right? If so, I will do it now.

Thank you so much. Chiara

rdbisme commented 4 years ago

You need to create a fork, than you'll be able to make a PR. There're plenty of guides online ;)

ChiaraAmato commented 4 years ago

I did create a Pull Request. Please, let me know if everything is ok. Thanks :)

jbscoggi commented 4 years ago

Closing since this was fixed in #123