mutationpp / Mutationpp

The MUlticomponent Thermodynamic And Transport library for IONized gases in C++

GNU Lesser General Public License v3.0

106 stars 58 forks source link

Fortran wrapper access to heavyThermalDiffusionRatios #121

Closed ChiaraAmato closed 4 years ago

ChiaraAmato commented 4 years ago

I have implemented the function "heavyThermalDiffusionRatios" in both cwrapper.h and cwrapper.cpp following the function "frozenThermalConductivity". However, when I run a testcase using N2 and O2, I received that the Thermal diffusion ratios are zero for both species. Furthermore, can you confirm that the "heavyThermalDiffusionRatios" function is evaluating the coefficients for the temperature term in the diffusive velocities for the Stefan-Maxwell equation?

codecov[bot] commented 4 years ago

Codecov Report

Merging #121 into master will not change coverage by %. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   70.07%   70.07%           
=======================================
  Files         134      134           
  Lines        8451     8451           
=======================================
  Hits         5922     5922           
  Misses       2529     2529

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5330d93...2d76473. Read the comment docs.

rdbisme commented 4 years ago

Ehi @ChiaraAmato, I don't see any changes wrt our master branch.

Did you commit and push your changes to your own fork?

ChiaraAmato commented 4 years ago

I thought I did. I am having trouble committing and pushing from the terminal. I don't know why it doesn't show me the changes here. Therefore, I added the files manually but I think those are just committed. I am figuring out why is not working. I will create a new pull request as soon as I fix it.

ChiaraAmato commented 4 years ago

Ok, I think I push them now. I can see the difference between my cwrapper.cpp and chapter.h. Can you confirm me that everything is ok now? Thanks

jbscoggi commented 4 years ago

Hi @ChiaraAmato, could you please do a merge with the latest version of the master branch in your fork and then recommit? It seems your changes will actually revert the copyright statements, which indicates you are not up to date with the latest version. Here are some instructions if you need help: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork.

ChiaraAmato commented 4 years ago

Ok, I will. I am sorry for the inconvenience

jbscoggi commented 4 years ago

No problem! We are very happy that you are contributing! :)

ChiaraAmato commented 4 years ago

Ok, I created a new pull request. It was easier this way. Can you please let me know if this time I have done everything properly? Thank you.

jbscoggi commented 4 years ago

Closing this in favor of #123.