Closed ChiaraAmato closed 4 years ago
Merging #123 into master will not change coverage by
%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 70.07% 70.07%
=======================================
Files 134 134
Lines 8451 8451
=======================================
Hits 5922 5922
Misses 2529 2529
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5330d93...8ee92ee. Read the comment docs.
Ok, I changed the files and pushed them. They should be as requested. I will tested them again using the new version of mutation++ and see if they work. Just to be sure, is the output of "heavy_thermal_diffusion_ratios", the ratios needed in the Stefan-Maxwell equation to evaluate the thermal diffusion?
Hi @ChiaraAmato, this looks good now, I will merge it. Thanks!
And yes these are the heavy thermal diffusion ratios you would need for the SM algorithm, but you would also need the electron thermal diffusion ratios if you have electrons in the mixture. You can get these with the electronThermalDiffusionRatios2
function in c++. I don't think this is available in the cwrapper so you will likely need to add that as well.
I'm going to go ahead and merge this though.
I think I fix the problem now. You should be able to see the modification I did on the write files. Hopefully, this is the right one. Thank you all for the help and the patience. I apologize for the problems I caused.