mutationpp / Mutationpp

The MUlticomponent Thermodynamic And Transport library for IONized gases in C++
GNU Lesser General Public License v3.0
101 stars 58 forks source link

Added entropy to python wrapper #214

Closed adelval1 closed 1 year ago

adelval1 commented 1 year ago

Added the function

.def("mixtureSMass", static_cast<double (Mutation::Mixture::*)(void) const>( &Mutation::Mixture::mixtureSMass), "Returns the mixture averaged entropy in J/kg-K.")

to pyMixture.cpp for usage in my soon-to-be-released python version of the CABARET code. People will need this update in their Mutationpp python modules.

rdbisme commented 1 year ago

Hello, what about the rest of the code changing how the Python wrapper is built? I have the feeling you have used an old branch maybe? They way the current branch is configured is that doing pip install . should correctly install the python package. In order to do this we use scikit-build.

Could you just add the code related to the function you mention and be sure it compiles? Bonus point will be to add an associated test written in Python using pytest in the root of the repo.

Let me know if you need further assistance.

codecov[bot] commented 1 year ago

Codecov Report

Merging #214 (b6d6d3c) into master (97ec997) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   71.25%   71.25%           
=======================================
  Files         135      135           
  Lines        8985     8985           
=======================================
  Hits         6402     6402           
  Misses       2583     2583           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97ec997...b6d6d3c. Read the comment docs.

rdbisme commented 1 year ago

Hello, the new push includes binary files (bin/*) that should not be there and lots of modifications on all the files. Maybe starting from current master and cherry picking modifications related to the entropy addition will be easier.

jbscoggi commented 1 year ago

Hey @adelval1, I agree with @rdbisme. I think it's best if you start from a fresh clone of the library. Have a look at this for some more info on the best workflow for contributing.