Closed adelval1 closed 1 year ago
Hello, what about the rest of the code changing how the Python wrapper is built? I have the feeling you have used an old branch maybe? They way the current branch is configured is that doing pip install .
should correctly install the python package. In order to do this we use scikit-build
.
Could you just add the code related to the function you mention and be sure it compiles? Bonus point will be to add an associated test written in Python using pytest
in the root of the repo.
Let me know if you need further assistance.
Merging #214 (b6d6d3c) into master (97ec997) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #214 +/- ##
=======================================
Coverage 71.25% 71.25%
=======================================
Files 135 135
Lines 8985 8985
=======================================
Hits 6402 6402
Misses 2583 2583
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 97ec997...b6d6d3c. Read the comment docs.
Hello, the new push includes binary files (bin/*
) that should not be there and lots of modifications on all the files. Maybe starting from current master
and cherry picking modifications related to the entropy
addition will be easier.
Added the function
.def("mixtureSMass", static_cast<double (Mutation::Mixture::*)(void) const>( &Mutation::Mixture::mixtureSMass), "Returns the mixture averaged entropy in J/kg-K.")
to pyMixture.cpp for usage in my soon-to-be-released python version of the CABARET code. People will need this update in their Mutationpp python modules.