mutationpp / Mutationpp

The MUlticomponent Thermodynamic And Transport library for IONized gases in C++
GNU Lesser General Public License v3.0
101 stars 58 forks source link

added instructions to build local python package #215

Closed ggange closed 10 months ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #215 (2ecabcd) into master (eb8ab74) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   71.48%   71.48%           
=======================================
  Files         135      135           
  Lines        9114     9114           
=======================================
  Hits         6515     6515           
  Misses       2599     2599           
Fratorhe commented 1 year ago

Hi,

It can be much easier. Simply do: pip install .

If you get an error related to PEP517 update essential packages: pip install --upgrade pip setuptools wheel

Best, Fran

rdbisme commented 1 year ago

As @Fratorhe said. Closing! :)

pip install . is enough.

As I have a bit of spare time I'll enable the push of the pre-compiled wheel to PyPi for super easy install.

rdbisme commented 1 year ago

Actually documenting what @Fratorhe said would be beneficial. :)

ggange commented 1 year ago

Hello @rdbisme, here are the updated instructions (I added a small remark regarding zsh on macOS, since it was object of another question!). Thank you (@Fratorhe to you too)!

rdbisme commented 10 months ago

Closing as stale. Feel free to re-open addressing the comments from me and @Fratorhe.

ggange commented 10 months ago

Hi @rdbisme, is there something missing in the installation.md that is preventing this merge? I should have included yours and @Fratorhe comments in the instructions...

rdbisme commented 10 months ago

Hi @rdbisme, is there something missing in the installation.md that is preventing this merge? I should have included yours and @Fratorhe comments in the instructions...

The section ## Build Python package locally is not correct. pip install . is enough. The rest of the information is redundant with what is in pyproject.toml and already taken into account by pip install ..

So the information about installing the Python wrappers is just Run pip install . in the root of the repo.

ggange commented 10 months ago

ok, thanks! Like this? :)