Update Catch third party library

mutationpp / Mutationpp

The MUlticomponent Thermodynamic And Transport library for IONized gases in C++

GNU Lesser General Public License v3.0

106 stars 57 forks source link

Update Catch third party library #229

Closed mgoodson-cvd closed 1 year ago

mgoodson-cvd commented 1 year ago

The CI/CD builds with ubuntu-latest have started failing due to the update to clang++ version 14 which does not allow variable length arrays. The issue arises in Catch, e.g., here. It would not be fun to have to update to Catch v2 or even worse v3 (which is no longer header-only). Thankfully, the Catch project maintains a Catch1.x branch which has a fix for this very issue.

mgoodson-cvd commented 1 year ago

I was able to use git-subrepo pull thirdparty/catch -b Catch1.x to update the version of Catch distributed with Mutation++, and I have confirmed that it fixes the issue with clang++ 14. I'll stack my fix on #211.