search

mutationpp / Mutationpp

The MUlticomponent Thermodynamic And Transport library for IONized gases in C++
GNU Lesser General Public License v3.0
101 stars 58 forks source link

Update pybind11 to v2.10.4 #230

Closed mgoodson-cvd closed 10 months ago

mgoodson-cvd commented 1 year ago

Required for pybind11 to work with python 3.11.4 in ubuntu 22.04 for CI/CD

See failure here

mgoodson-cvd commented 1 year ago

I'm going to update this to use git-subrepo (similar to the way you've done catch and eigen) rather than a "local" git submodule (.gitmodules was pointing to ../../pybind/pybind11 rather than https://github.com/pybind/pybind11). I'll stack this on #211 as well.

rdbisme commented 1 year ago

Hello @mgoodson-cvd. Thanks a lot for your work. Any chance you can put this in a separate PR? That way I cann approve it. The "scientific" part is @jbscoggi realm! :)

mgoodson-cvd commented 1 year ago

Sure. Okay if I combine with #229 so that the CI/CD will pass?

rdbisme commented 12 months ago

Yep!