mutationpp / Mutationpp

The MUlticomponent Thermodynamic And Transport library for IONized gases in C++

GNU Lesser General Public License v3.0

101 stars 58 forks source link

Closes #229, #230, #232, #237. #233

Closed mgoodson-cvd closed 10 months ago

mgoodson-cvd commented 12 months ago

~~Closes #221. Fixes bug in python interface with averageHeavyCollisionFreq returning incorrect value.~~

Closes #229. Updates the Catch2 third-party library.

Closes #230. Updates pybind11 third-party library to v2.10.4.

Closes #232. Fixes bug with getChildElementObject function not returning a value.

Closes #237. Removes ubuntu-18.04 from GitHub build actions.

mgoodson-cvd commented 12 months ago

@rdbisme I tacked on #232 as it is necessary for the CI/CD compilation to be successful, and #221 because it is a straightforward bug in the Python. I can remove #221 if you'd prefer to keep it separate; I already have an open PR #222 for that one, but it was failing CI/CD due to the issues addressed here.

mgoodson-cvd commented 12 months ago

221 caused the Python failure for some reason. I'll remove it from this PR and track it down and update #222 separately.

codecov[bot] commented 12 months ago

Codecov Report

Merging #233 (37ae9ce) into master (4cb6e3a) will increase coverage by 0.23%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   71.25%   71.48%   +0.23%     
==========================================
  Files         135      135              
  Lines        8985     9114     +129     
==========================================
+ Hits         6402     6515     +113     
- Misses       2583     2599      +16

Files Changed	Coverage Δ
src/utilities/XMLite.h	`100.00% <ø> (ø)`

... and 55 files with indirect coverage changes

mgoodson-cvd commented 10 months ago

This will need to be manually merged due to the ubuntu-18.04 actions still attempting to build (based on what is on master), but they will always fail now because of #237.

@rdbisme Any objections to me merging manually?