search

mutationpp / Mutationpp

The MUlticomponent Thermodynamic And Transport library for IONized gases in C++
GNU Lesser General Public License v3.0
108 stars 58 forks source link

48 omega i bug #54

Closed amorosej closed 5 years ago

amorosej commented 5 years ago

Removed the +/-1 factor and added reactions types that should be considered for this transfer term.

codecov-io commented 5 years ago

Codecov Report

Merging #54 into master will increase coverage by <.01%. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   66.23%   66.24%   +<.01%     
==========================================
  Files         234      234              
  Lines       11300    11310      +10     
==========================================
+ Hits         7485     7492       +7     
- Misses       3815     3818       +3
Impacted Files Coverage Δ
src/kinetics/RateManager.h 100% <100%> (ø) :arrow_up:
src/transfer/OmegaI.cpp 100% <100%> (+3.03%) :arrow_up:
src/kinetics/Kinetics.cpp 76.81% <25%> (-1.55%) :arrow_down:
src/kinetics/RateManager.cpp 93.02% <80%> (-2.1%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fc3ff95...1e7ff00. Read the comment docs.

jbscoggi commented 5 years ago

Hey @amorosej, there seems to be a mix-up with this PR and #53 because they both have the same commit regarding the irreversible reactions fix. I'm going to close this so you can create a fresh PR that only deals with the OmegaI problem to not pollute the conversation. Note that this PR also seems to break some tests. You can run the tests on yourself in order to make sure that they at least pass on your computer first, before submitting the PR next time.