search

mutationpp / Mutationpp

The MUlticomponent Thermodynamic And Transport library for IONized gases in C++
GNU Lesser General Public License v3.0
106 stars 58 forks source link

Floating point error using only one species in mppequil #94

Closed jbscoggi closed 4 years ago

jbscoggi commented 5 years ago

Refer to #85 for an example.

elsalaaarsson commented 5 years ago

Trying to run the same command as you in #85 I get the following:

mppequil --species-list "NH3" --thermo-db "NASA-9" -T 1548 -P 1106507.818257603 -m 3,5,9,24,32,3
   rho[kg/m^3]    Mw[kg/mol]  Cp_eq[J/kg-K]     Hf[J/mol]      mu[Pa-s]   rho[kg/m^3]
Floating point exception (core dumped)
rdbisme commented 5 years ago

I think the different error depends on the compiler/OS. Probably on macOs it does not crash on floating point exception but instead returns a nan.

elsalaaarsson commented 5 years ago

Thanks, @rubendibattista , that would make sense.

elsalaaarsson commented 5 years ago

Hey, how is this bug coming along? :)

jbscoggi commented 5 years ago

Hey @elsalaaarsson, I'm sorry I have been very busy the last two weeks. I will try and take a look at it this weekend.

elsalaaarsson commented 5 years ago

No worries!

jbscoggi commented 4 years ago

Hey @elsalaaarsson, I realize this is pretty late and you probably moved on but I just pushed a fix for this. I hope it can still be helpful.