mutecomm / go-sqlcipher

Self-contained Go sqlite3 driver with an AES-256 encrypted sqlite3 database
Other
167 stars 62 forks source link

Upgrade to sqlcipher 4.2.0 #9

Closed andremedeiros closed 4 years ago

andremedeiros commented 4 years ago

This PR upgrades SQLCipher to 4.2.0

I'm not sure about the extra methods/fields that are mentioned on a separate issue because the tests pass, and that kinda scares me.

Can you validate that this is correct?

frankbraun commented 4 years ago

I just looked into this and your patches where indeed correct.

Since the 4.x series of SQLCipher is incompatible to the 3.x series and we are already at 4.4.0 now I went ahead and upgraded to that instead with a new import path. So for that reason I won't merge your PR, but thanks nonetheless!

See Incompatibilities of SQLCipher for details.

What's still pretty outdated is the source from go-sqlite3, they are from 2017-04-08.