muter-mutation-testing / muter

🔎 Automated mutation testing for Swift 🕳️
MIT License
496 stars 39 forks source link

Reconsider defaultExcludeList values to be more specific #259

Closed Nikoloutsos closed 7 months ago

Nikoloutsos commented 9 months ago

This is the code we currently have:

private var defaultExcludeList: [FilePath] {
        [
            ".swiftpm",
            ".build",
            "Build",
            "Carthage",
            "muter_tmp",
            "Pods",
            "Spec",
            "Test",
            "fastlane"
        ]
    }

The problem with the above code is that if I have a file named SpecialFeatureViewModel it will be excluded.

So I am proposing we change them like \Spec\ which will exclude every file that is inside Spec folder. And of course this will have to work for both linux and macos (we can see how we can achieve this).

What do you think? @rakaramos @ZevEisenberg

ZevEisenberg commented 9 months ago

Makes sense to me. We will probably need to add a few more entries to the default list, like Tests.

Nikoloutsos commented 9 months ago

@ZevEisenberg I've added Tests folder as you mentioned. If you have some time please give me a review on https://github.com/muter-mutation-testing/muter/pull/258

rakaramos commented 7 months ago

@Nikoloutsos closing this one as it was fixed in #258