RemoveSideEffectsOperator doesn't check for implicit return scenario

[hoangatuan]

Describe the bug

If a function uses an implicit return, RemoveSideEffectsOperator treats it as a side effect and removes it.

To Reproduce

Given this piece of code:

func calculate() -> Int {
    calculateSth()
}

func calculateSth() -> Int {
    return 2
}

Current behavior

After running Muter, here is the generated code, which cause compile error:

func calculate() -> Int {
    if ProcessInfo.processInfo.environment["AlgoService_118_23_2615"] != nil {
    } else {
        calculateSth()
    }
}

func calculateSth() -> Int {
    return 2
}

Expected behavior

Implicit return is not side effect, so we shouldn't remove it

func calculate() -> Int {
        calculateSth()
}

func calculateSth() -> Int {
        return 2
}

[hoangatuan]

@rakaramos @ZevEisenberg Hi, please take a look. I can help to fix this issue

[rakaramos]

hi @hoangatuan, which version of Muter are you using, on 16 (installed using brew) this is skipped. could you please try with that version? Or, if not possible, use muter:disable while the fix isn't there yet?

[hoangatuan]

Hi @rakaramos, I'm using the latest code on master branch

[hoangatuan]

I just checked. You've removed the logic check for implicit return in the change recently