search

muter-mutation-testing / muter

🔎 Automated mutation testing for Swift 🕳️
MIT License
502 stars 39 forks source link

[257]: Fix bug crash if using non alphabet character #270

Closed hoangatuan closed 7 months ago

hoangatuan commented 9 months ago

What it Does

rakaramos commented 9 months ago

@hoangatuan nice improvement! I was wondering if we could maybe ignore the mutation in this case. This whole logic is super fragile and easily breaks (I've been heavily testing muter on other projects). I've been studying new ways to implement this mutation because this one is a mixture of token positions and a lot of juggling with string indexes :(

hoangatuan commented 9 months ago

@rakaramos I'm not sure if we should ignore mutation for the scenario when the developer uses non-alphabet character. For example, the logic can be like: 

     if value == "バルーンの表示判定" {
          ...
     }

Besides, I haven't read the logic of discovering mutation in depth. I will try to take a look to see if we can improve it

hoangatuan commented 8 months ago

@rakaramos I think your linux branch will have some conflict with my branch. I will rebase this branch and update it after you merge the linux branch

hoangatuan commented 8 months ago

@rakaramos I've rebased and updated my PR