search

mutewinter / Showbot

🤖 An IRC Bot and Website for 5by5.tv written with the Cinch and Sinatra frameworks
MIT License
90 stars 31 forks source link

Upgrade to Cinch 2.0 #36

Closed mutewinter closed 11 years ago

mutewinter commented 12 years ago

Need to upgrade the gem and verify the main functionality of Showbot still works.

rikai commented 12 years ago

I'm actually working on this as well as updating to the latest cinchize. Progress is a bit slow, but i'm slowly working through it.

rikai commented 11 years ago

Progress of this can be tracked in https://github.com/rikai/Showbot/commits/master

It starts now, but most of the plugins need some work to finish correcting them for the new system. Debugging them is extremely slow for me due to lack of really any experience with ruby at all, so help from anyone is welcome.

There are some minor changes, most of which are temporary. Namely the use of another network/channel for testing in the code, and the bypassing of showbot_irc.rb during development.

Also added a !time command while i was working to tell you the time of whatever timezone you specify.

Nickserv identification is also added in this fork, thanks to the ability to use cinch-identify after the transition to cinch 2.0. This fork will also allow for centralized plugin configuration with modifications to the current plugins, as can be seen already with cinch-identify settings being defined in cinchize.yml instead of the plugin. :)

Still a decent amount to do with the plugins, but the base fires up and runs under the latest cinch/cinchize, so a good chunk of the work is done. Figure'd i'd post a status update here. :)

Edit: I backed out a few commits and made some changes after this post. Some commits were made before I figured out the PATH/RUBYLIB issues i was having, and therefore were mistaken. The plugins are now back in the Cinch::Plugins namespace rather than the global namespace like they had been, as well as reverting a folder change that wasn't actually needed. Sorry for the mess. :x

My main blocker now is figuring out the correct way to do showbot_irc.rb with the new cinchize... i guess i need to do Cinchize.config? but i really don't understand how to set that up. I'm in over my head in this bit, i think. Any advice?

rikai commented 11 years ago

There we go, that pull request should fix this completely and without tainting upstream with my custom modifications too.

A fair amount of the commited changes i had made were due to inexperience and made the fork a bit messy, so i started over from a fresh fork and things came out much cleaner this time around. No plugin modifications were needed after all, just some reworking of showbot_irc, the procfiles, Gemfiles and cinchize.yml.

Also took the opportunity to implement #34.

I left the !time command i added out of this pull request since its out of scope. Can add it as a seperate pull request if you're interested