mutewinter / tapas-with-ember

🚫 UNMAINTAINED: A Brunch skeleton for rapid Ember development. Including Ember installation scripts, environment-specific JS builds, generators, and Ember.vim support.
Other
127 stars 19 forks source link

cake build outputs DIGEST(styles/app.css) in public/index.html #14

Closed millisami closed 10 years ago

millisami commented 10 years ago

@mutewinter , here is another issue when running cake build. This popped up when I tried to deploy another app on to heroku.

To reproduce this, I've put-up the repo at https://github.com/millisami/deployed-ember Clone it, bower install and npm install Then run cake build and open up public/index.html

<link rel="stylesheet" href="DIGEST(styles/app.css)">
    <script src="DIGEST(scripts/vendor.js)" defer></script>
    <script src="DIGEST(scripts/app.js)" defer onload="require('initialize');">
    </script>

Why that DIGEST(...) is attached into it. Its breaking my build of the sample app?

millisami commented 10 years ago

But if I change the config.coffee section stylesheets to following:

    stylesheets:
      joinTo:
        'styles/app.css': /^(app|vendor)/
      order:
        before: ['vendor/styles/normalize.css']

That DIGEST(..) part is removed. But if I change that to:

    stylesheets:
      joinTo:
        'stylesheets/app.css': /^(app|vendor\/(?!node))/
      order:
        before: ['vendor/styles/normalize.css']

which is the fix for Heroku bug https://github.com/mutewinter/tapas-with-ember/issues/13

I get the

<link rel="stylesheet" href="DIGEST(styles/app.css)">
    <script src="DIGEST(scripts/vendor.js)" defer></script>
    <script src="DIGEST(scripts/app.js)" defer onload="require('initialize');">
    </script>
mutewinter commented 10 years ago

I figured out the problem. It has to do with digest-brunch.

Your problem is that this line creates the stylesheets in public/stylesheets, but your index.html references it in the styles folder. Digest-brunch isn't handling this situation gracefully, and just crashes instead of continuing processing.

I created mutewinter/digest-brunch#4 in digest-brunch to fix this problem. Thanks for finding it!