Report AngelScript bugs (and praise) to developer

zelerin commented 5 years ago

While integrating AngelScript with MUTGOS, some bugs (or potential bugs) were found. These should be reported to the developer and/or better understood:

scriptarray (from add_ons), has an area in Precache() where it doesn't check for an out of memory condition. I fixed it for inclusion into MUTGOS but it needs to be reported.
asUnprepareMultithread() causes crash when shutting down MUTGOS; find out if we're just using it wrong.
Research/report/understand potential Valgrind memory leaks: AngelScript is not garbage collecting all objects when expected (in particular, the main() arguments - an AString, and arrays - a cscriptarray).

Also, let the developer know how great AngelScript is and that it is a core piece to MUTGOS.

zelerin commented 5 years ago

I just emailed the praise, now I just need to upgrade to the latest version (issue #24) before asking my questions

zelerin commented 5 years ago

The asUnprepareMultithread() crash was an error on my part (being called twice). The fix will be checked in under this issue.

zelerin commented 5 years ago

Send out bug reports/questions and will see what happens!

zelerin commented 5 years ago

Waiting to hear back from AS primary developer on how it internally handles out of memory conditions. After that, I can close this issue.

zelerin commented 5 years ago

The primary developer said AS is supposed to be able to handle an out of memory condition at any time. I may have to test that later. For now, all my known issues with AS and memory management are resolved, and I have a 'best practices' moving forward.

The primary developer is also very responsive, and will make fixes as issues are found.

mutgos / mutgos_server

Report AngelScript bugs (and praise) to developer #26