HARViewer not compatible with JQuery >= 1.9

[GoogleCodeExporter]

The "browser" object has been removed in JQuery 1.9 and as this is still used 
by domplate.js this raises an exception and HARViewer does not work properly.

This can be mitigated by using the jquery-migration plugin.

You can see the bug in, er, inaction over at 
http://bayou.clark-consulting.eu/site/6459/

Original issue reported on code.google.com by charlie....@clark-consulting.eu on 13 Mar 2013 at 6:54

[GoogleCodeExporter]

Any tips for what to use to replace the |browser| object?
Honza

Original comment by odva...@gmail.com on 13 Mar 2013 at 7:14

[GoogleCodeExporter]

Sorry, no. My Javascript knowledges is very superficial.

I was looking at the docs earlier and it just says use Modernizr. I just stuck 
in the Migrate plugin but that just seems to remove the exception. What do you 
actually need it for?

Maybe in the meantime a hard-coded alert based on checking the JQuery version?

Original comment by charlie....@clark-consulting.eu on 13 Mar 2013 at 7:36

[GoogleCodeExporter]

> What do you actually need it for?
Browser detection, see e.g. here:
https://github.com/janodvarko/harviewer/blob/master/webapp/scripts/domplate/domp
late.js#L117

Honza

Original comment by odva...@gmail.com on 13 Mar 2013 at 7:43

[GoogleCodeExporter]

That really looks like the sort of thing that you can do with Modernizr. Is 
that the only instance?

According to https://github.com/jquery/jquery-migrate/blob/master/warnings.md 
you can use more primitive browser detection methods including the user agent 
directly instead. As it looks like you are only checking for Internet Explorer 
a primitive approach should be perfectly acceptable. Something like 
https://gist.github.com/padolsey/527683 might do the trick and probably how 
Modernizt does it.

Original comment by charlie....@clark-consulting.eu on 13 Mar 2013 at 8:14

[GoogleCodeExporter]

I hacked in the function suggested in the gist and it seems to work.

Original comment by charlie....@clark-consulting.eu on 14 Mar 2013 at 10:02

Attachments:

• jquery19.diff

[GoogleCodeExporter]

Thanks for the patch!
I'll review and commit soon.

Honza

Original comment by odva...@gmail.com on 14 Mar 2013 at 3:58

[GoogleCodeExporter]

It's more of a hack than a patch! ;-) I only realised this morning that you 
embed JQuery 1.5 into the project. I would have thought making an explicit 
dependency or a subrepository makes more sense. For example, I have Harviewer 
linked in my own repository 
https://bitbucket.org/charlie_x/python-httparchive/src/db253d0ba07d/.hgsub?at=de
fault

FWIW I also seem to have hit problems with the id of the placeholder tag 
"content" being hardwired into Harpreviewer but it's proving a bit difficult to 
provide reproducible errors.

Original comment by charlie....@clark-consulting.eu on 14 Mar 2013 at 4:10

[GoogleCodeExporter]

Hi Honza,

just letting you know that I reverted my changes locally and went back to 
JQuery 1.8.3, the most recent version without significant problems. I have 
discovered the following two: there seems to be an incompatibility with the 
Google Visualisation Library so you get not fatal errors when you mouse over 
GViz charts on a page with HARViewer. I suspect that this is probably down to 
HARViewer binding events in the charts. I was thinking it would be possible to 
remedy this using the async, iframe-based approach but I a problem with this 
having a hard coded requirement for the PHP file to return the JSON. I actually 
don't see any real need for this in core HARViewer code and will see if I can 
supply a replacement that will allow this to be backend neutral. Pull-request 
assuming I can figure out git.

The other problem I have is that the waterfall appears in a different place 
depending on browser. In Opera, my standard, there is no problem but in Firefox 
the waterfall appears as the last item on the page. Any ideas what's causing 
that?

Original comment by charlie....@clark-consulting.eu on 24 Mar 2013 at 4:52