mutoh / gettext

Ruby-GetText-Package is a Localization(L10n) library and tools which modeled after GNU gettext package.
http://www.rubyforge.org/projects/gettext/
Other
68 stars 41 forks source link

include msgctxt when generating .po file #12

Open 3dd13 opened 13 years ago

3dd13 commented 13 years ago

I am using the function to parse, modify and print out .po file in my project, but I found out that context was not handled in po generation. so, this is my fix.

nikosd commented 12 years ago

@3dd13 are you sure about this? Can you give an example of what's not working? I know that you have added a test but I don't get 100% the case cause I'm not so familiar with the GetText::RMsgMerge::PoData api...

3dd13 commented 12 years ago

@nikosd

sorry, my test case was not clear enough. it was the msgctxt "Context" not being printed out.

the story was ... I parsed a .pot file and generate a .po file and found out that the msgctxt was missing in the output .po file.

nikosd commented 12 years ago

@3dd13 thanks for the clarification! I will try to co and run the test to cast my vote. This looks useful.

kou commented 12 years ago

I've merged those changes in https://github.com/ruby-gettext/gettext/commit/3518c4d70bed59943e6299d889cf97834573bd23 Thanks!