search

mutualmobile / MMSpreadsheetView

MIT License
193 stars 34 forks source link

Grid lines improvements #1

Closed cadious closed 11 years ago

cadious commented 11 years ago

It would be nice to have a property that would set the width of the grid lines. Also setting the color of the grid by changing the control's background is misleading. It would be nice to have a separate property for this.

jeffla commented 11 years ago

@cadious Do all lines for all views adjust or just some? What if you have locked rows or columns and is a separate property needed for that? If you just need some lines to increase, you might achieve the same affect by drawing a border on your cells. If you don't have headers, a simple UICollectionView with the MMGridLayout class adjusted to your needs may work. I'd be happy to review a pull request for this! :beers:

The gridlines you see are actually the UICollectionView's background instead of an actual line being drawn as in UITableView so for the current implementation, the background color is the only way to set the "line color" for the control.

cadious commented 11 years ago

@jeffla Actually what i'm trying to do is remove all those line, so I thought if I set the width of the lines to zero they would not be visible.

jeffla commented 11 years ago

Added a cellSpacing property to MMGridLayout 0.0.2.