Tool timeouts because timeouts are too low

muun / recovery

Muun recovery tool

https://muun.com

MIT License

199 stars 79 forks source link

Tool timeouts because timeouts are too low #10

Closed Dantesic closed 2 years ago

Dantesic commented 2 years ago

Hi,

I have tried to use your official tool version but I could not get it to work. I have then cloned your code and increased all timeouts and build executable again.

With increased timeouts tool finished correctly!

Official version

My version with increased timeouts

If you need exact values, I can make you pull request, It would be nice if you could fix this since I would like to recommend your tool to my clients.

My system is MacBook pro 2021 M1, Mac Os Monteray 12.2.1

champo commented 2 years ago

hi! Thanks for looking into this! How high did you have to set the timeouts? Just to be sure, you're talking about the taskTimeout defined in scanner.go right?

Dantesic commented 2 years ago

I'm not sure which one of these is because I did not test further, If you suspect some specific parameter, I can try and run again

champo commented 2 years ago

Oh you were very thorough! Given the screenshot from the time it failed, I suspect the issue lies with the one I mentioned before. If a server doesn't support batching 2 minutes might not be enough to resolve all the addresses in the task. I'll send a PR for this later today!

champo commented 2 years ago

Raised all the relevant timeouts here. Be sure to let us know if anything else pops up! Thanks

Dantesic commented 2 years ago

Great! Good luck with the business.