search

muvox-io / euphonium

Tiny audio platform
GNU Affero General Public License v3.0
96 stars 15 forks source link

adding requirements file and updating docs to point to this #34

Closed TooDissing closed 2 years ago

TooDissing commented 2 years ago
TooDissing commented 2 years ago

Hi Filip,

I can see that the build failed with missing files. Is this a known issue?

If not, please, can you provide me with a hint to two. Then I’ll have a go at addressing it.

HeikoGr commented 2 years ago

file check was initiated by me.

The error is caused in the file euphonium/.github/workflows/esp-idf.yml on line 63. it’s because the var ${{github.ref_name}} is set to 'euphonium-34/merge' in this merge for pr34.

the error does not occur on a "normal" commit or release trigger.

I have no idea how to fix it properly.

feelfreelinux commented 2 years ago

The issue with failed builds in PRs is a separate one. Looks like adding requirements.txt somehow broke the docs / mkdocs pipeline, I'll take a look at it shortly. Everything else seems fine, firmware itself builds just fine too so thanks a lot for the contribution!

HeikoGr commented 2 years ago

looks like there is no pip wheel for latest grpcio on alpine linux.

i tried to fix it in PR #35