muxall / RPTCQ-LCD

Muxall Remote Programmable Temp Controller Model Q (for BBQ) LCD Library
MIT License
1 stars 0 forks source link

Issue: DHCP can be set to Disabled if data coming into the controller has corrupted data. #167

Open muxall opened 3 months ago

muxall commented 3 months ago

Observed: Several customers have reported DHCP being disabled with an IP address of 0.0.0.0 which is an invalid IP address.

Expected: DHCP should not be disabled if the IP address is 0.0.0.0.

Findings: Originally it was thought the DHCP bit was getting corrupted during a software update. However, it was reproduced by a customer on two of his controllers after changing out a WiFi router. After digging around, it was discovered that there is a bug in an “else” statement that defaults the isDHCP variable to 0 if the isDHCP variable is corrupted in the data stream.

Since this bug is very difficult to reproduce, checks were also added to the code that reverts the isDHCP variable back to 1 if it sees an invalid IP address at boot up and during a config “save” by the user.