search

muxinc / hls-video-element

A custom element (web component) for playing HTTP Live Streaming (HLS) videos.
https://hls-video-element-mux.vercel.app
MIT License
38 stars 18 forks source link

video is not defined #10

Closed Nodalailama closed 2 years ago

Nodalailama commented 2 years ago

Hi,

https://github.com/muxinc/hls-video-element/blob/57c4a5e32ba87536604e2b751bb60a5db87b0e78/index.js#L35

video.canPlayType should be replaced by this.nativeEl.canPlayType

Cordialement,

jools-r commented 2 years ago

Observing this too in Mobile Safari iOS 15.4.1 but not on desktop Safari when using:

<script type="module" src="https://unpkg.com/hls-video-element@0.0"></script>

in conjunction with Media Chrome. The poster image loads but the video itself doesn't.

You can observe this on the Media Chrome HLS Media Demo too.

ReferenceError: Can't find variable: video

ReferenceError: Can't find variable: video
load hls – video-element.js:84:1170
connectedCallback – hls-video-element.js:84:1275
define
Modulcode – hls-video-element.js:84:1348
evaluate
moduleEvaluation
(anonyme Funktion)
promiseReactionJob

If I'm reading it correctly, Nodalailama provided a PR but as it's not incorporated, it's not part of the version on unpkg.com.