search

muxinc / hls-video-element

A custom element (web component) for playing HTTP Live Streaming (HLS) videos.
https://hls-video-element-mux.vercel.app
MIT License
38 stars 18 forks source link

Fixes autoplay not working correctly #21

Closed evoactivity closed 1 year ago

evoactivity commented 1 year ago

Resolves #16

luwes commented 1 year ago

@evoactivity thanks for the work!

I believe this bug might be related to the older pkg https://github.com/muxinc/custom-video-element

the plan is to add the new https://github.com/muxinc/custom-media-element here. we should try that first to see if it fixes this bug

evoactivity commented 1 year ago

I am planning on trying that tonight. Though I think a similar solution will still be necessary, I found autoplay to be inconsistent between refreshes when I wrote a my mpegts element and resorted to a similar strategy of calling play manually on load.

evoactivity commented 1 year ago

@luwes Would moving the repo to vite and typescript potentially be a blocker for you guys or would that be something you welcome?

evoactivity commented 1 year ago

Updating to use custom-media-element seems to have resolved the issue in my case, without this change, so I'm going to close it.

luwes commented 1 year ago

yes, I think we want to hold off on Typescript for this size of project and Vite as well.

if we would replace bundler it would probably be esbuild but we might do away with bundling like in my fork https://github.com/luwes/hls-video-element

evoactivity commented 1 year ago

Oh cool, your fork does a lot of stuff I was considering adding in my fork so I'll hold off on anymore PR's here until there is time to merge your work.