search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.83k stars 76 forks source link

fix: Use overflow clip in tooltip button to prevent scrollbar #1002

Closed JeroenReumkens closed 1 month ago

JeroenReumkens commented 1 month ago

In #994 overflow-x: hidden was added to the tooltips to prevent unwanted overflows. hidden on a single axis does however introduce scrollbars on Windows devices and Mac's who enabled scrollbars to show always (this is great to emulate how a big part of users see your website, which is why I have it enabled).

Changing the overflow to overflow-x: clip will achieve the same result, but won't show a scrollbar. Which is what I added in this PR. See video below showcasing the issue and fix. Let me know your thoughts.

cc @luwes

Fixes #1000

https://github.com/user-attachments/assets/67509a11-099f-4b02-ba35-1e0acc46d003

vercel[bot] commented 1 month ago

@JeroenReumkens is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

bhatvikrant commented 1 month ago

🫡

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 3:12pm