search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.83k stars 76 forks source link

fix: tooltip overflow causing scrollbar #1018

Closed luwes closed 4 weeks ago

luwes commented 4 weeks ago

fix #1017 related https://github.com/muxinc/elements/issues/865

height[bot] commented 4 weeks ago

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

vercel[bot] commented 4 weeks ago

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 3:21pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 3:21pm
codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.95%. Comparing base (3ea80df) to head (c2329d7). Report is 137 commits behind head on main.

Files with missing lines Patch % Lines
src/js/utils/element-utils.ts 60.00% 2 Missing :warning:
src/js/media-tooltip.ts 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1018 +/- ## ========================================== - Coverage 78.55% 76.95% -1.61% ========================================== Files 59 50 -9 Lines 11080 12124 +1044 Branches 0 705 +705 ========================================== + Hits 8704 9330 +626 - Misses 2376 2768 +392 - Partials 0 26 +26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.