muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.77k stars 71 forks source link

fix: remove pointer events from hidden list boxes #725

Closed AdamJaggard closed 1 year ago

AdamJaggard commented 1 year ago
image

Some parts of a hidden listbox are still selectable even though they are hidden, particularly the nested SVG's. This makes them grab focus when moving the cursor or clicking.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 2:47pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 2:47pm
codecov[bot] commented 1 year ago

Codecov Report

Merging #725 (087c5e2) into main (bc95f55) will increase coverage by 0.01%. Report is 5 commits behind head on main. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
+ Coverage   80.02%   80.03%   +0.01%     
==========================================
  Files          53       53              
  Lines        9908     9914       +6     
==========================================
+ Hits         7929     7935       +6     
  Misses       1979     1979              
Files Changed Coverage Δ
src/js/experimental/media-captions-selectmenu.js 100.00% <100.00%> (ø)
src/js/experimental/media-chrome-option.js 96.01% <100.00%> (+0.10%) :arrow_up:
src/js/experimental/media-chrome-selectmenu.js 63.93% <100.00%> (+0.10%) :arrow_up:
.../js/experimental/media-playback-rate-selectmenu.js 100.00% <100.00%> (ø)
src/js/experimental/media-rendition-selectmenu.js 100.00% <100.00%> (ø)