muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.77k stars 71 forks source link

feat: add control-menu prototype (WIP) #762

Closed luwes closed 11 months ago

luwes commented 1 year ago

test url: https://media-chrome-git-fork-luwes-control-menu-mux.vercel.app/examples/vanilla/control-elements/media-control-menu.html

adds 2 new elements <media-control-menu> and <media-control-menu-button>.

<media-control-menu> is meant to be above the control bar and can be shown / hidden w/ <media-control-menu-button>

the linking is automatically done contained in media-controller or you can link them with target, id attributes.

there's a bunch of stuff missing, this is just a prototype.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 5:06pm
vercel[bot] commented 1 year ago

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 128 lines in your changes are missing coverage. Please review.

Comparison is base (bbc81d7) 79.10% compared to head (6b1acf2) 78.39%. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #762 +/- ## ========================================== - Coverage 79.10% 78.39% -0.72% ========================================== Files 58 61 +3 Lines 10471 10713 +242 ========================================== + Hits 8283 8398 +115 - Misses 2188 2315 +127 ``` | [Files](https://app.codecov.io/gh/muxinc/media-chrome/pull/762?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=muxinc) | Coverage Δ | | |---|---|---| | [src/js/experimental/index.js](https://app.codecov.io/gh/muxinc/media-chrome/pull/762?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=muxinc#diff-c3JjL2pzL2V4cGVyaW1lbnRhbC9pbmRleC5qcw==) | `100.00% <100.00%> (ø)` | | | [src/js/experimental/media-chrome-listbox.js](https://app.codecov.io/gh/muxinc/media-chrome/pull/762?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=muxinc#diff-c3JjL2pzL2V4cGVyaW1lbnRhbC9tZWRpYS1jaHJvbWUtbGlzdGJveC5qcw==) | `64.97% <100.00%> (ø)` | | | [src/js/media-chrome-button.js](https://app.codecov.io/gh/muxinc/media-chrome/pull/762?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=muxinc#diff-c3JjL2pzL21lZGlhLWNocm9tZS1idXR0b24uanM=) | `89.91% <100.00%> (ø)` | | | [src/js/media-playback-rate-button.js](https://app.codecov.io/gh/muxinc/media-chrome/pull/762?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=muxinc#diff-c3JjL2pzL21lZGlhLXBsYXliYWNrLXJhdGUtYnV0dG9uLmpz) | `78.94% <100.00%> (ø)` | | | [src/js/utils/element-utils.js](https://app.codecov.io/gh/muxinc/media-chrome/pull/762?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=muxinc#diff-c3JjL2pzL3V0aWxzL2VsZW1lbnQtdXRpbHMuanM=) | `88.32% <100.00%> (+0.11%)` | :arrow_up: | | [src/js/utils/events.js](https://app.codecov.io/gh/muxinc/media-chrome/pull/762?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=muxinc#diff-c3JjL2pzL3V0aWxzL2V2ZW50cy5qcw==) | `26.31% <26.31%> (ø)` | | | [src/js/experimental/media-chrome-selectmenu.js](https://app.codecov.io/gh/muxinc/media-chrome/pull/762?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=muxinc#diff-c3JjL2pzL2V4cGVyaW1lbnRhbC9tZWRpYS1jaHJvbWUtc2VsZWN0bWVudS5qcw==) | `57.56% <35.71%> (-3.91%)` | :arrow_down: | | [src/js/experimental/media-control-menu-button.js](https://app.codecov.io/gh/muxinc/media-chrome/pull/762?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=muxinc#diff-c3JjL2pzL2V4cGVyaW1lbnRhbC9tZWRpYS1jb250cm9sLW1lbnUtYnV0dG9uLmpz) | `60.81% <60.81%> (ø)` | | | [src/js/experimental/media-control-menu.js](https://app.codecov.io/gh/muxinc/media-chrome/pull/762?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=muxinc#diff-c3JjL2pzL2V4cGVyaW1lbnRhbC9tZWRpYS1jb250cm9sLW1lbnUuanM=) | `49.56% <49.56%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

luwes commented 11 months ago

closing for now until revisiting role=menu