search

muxinc / media-chrome

Custom elements (web components) for making audio and video player controls that look great in your website or app.
https://media-chrome.org
MIT License
1.77k stars 71 forks source link

fix: Android toggle controls on tapping #766

Closed luwes closed 1 year ago

luwes commented 1 year ago

this change fixes an issue where tapping the player on Android would show and hide the controls right away instead of scheduling the hiding after a timeout.

also fixes a small issue where the time range animation would not start right away when the time range became visible, the animation is disabled when it gets hidden to save CPU.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 4:17pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 4:17pm
vercel[bot] commented 1 year ago

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (dfe7206) 79.10% compared to head (4caa4a8) 78.89%. Report is 1 commits behind head on main.

:exclamation: Current head 4caa4a8 differs from pull request most recent head 8da3239. Consider uploading reports for the commit 8da3239 to get more accurate results

Files Patch % Lines
src/js/media-container.js 15.78% 80 Missing :warning:
src/js/media-time-range.js 66.66% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #766 +/- ## ========================================== - Coverage 79.10% 78.89% -0.22% ========================================== Files 58 58 Lines 10471 10499 +28 ========================================== Hits 8283 8283 - Misses 2188 2216 +28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.